Much thx to Ian Wadham!

July 5, 2009

In one of my last posts I indicated that Kolf 1.9 could possibly not be released with KDE 4.3 because it fails to load its objects. The same panic was expressed by me on the mailing list, and (as usual šŸ˜‰ my plans worked out: My panic made Ian Wadham, one of our kdegames hackers from Australia, dive into the Kolf 1.9 code (that pile of mud I talked about earlier) and find the cause of the bug.

The problem was that Kolf was relying on some unspecified behavior of KConfig::groupList(), which returned a sorted list of group names in KDE 4.2, but not in KDE 4.3. Such a change is of course legitimate, because the KConfig developers never stated that KConfig::groupList() would return a sorted list.

If you’ve got a current trunk snapshot (I think the fix is in trunk since yesterday), please check whether Kolf can correctly load holes (not only the first hole of a course, but also the following ones!). If you run into problems, please write to the kde-games-devel mailing list quickly. Thanks.


4 Responses to “Much thx to Ian Wadham!”

  1. atomopawn Says:

    Before updating, the USA Pro course (strict mode) with two players, the first hole worked fine, but the second hole was broken. After an update to latest trunk it is working fine for me on all holes. Thanks, Ian and Stefan!

  2. Kudos to Ian, thanks for the excellent detective work.
    On a personal note, Stefan, I do not agree with your characterization of Kolf 1.x. It is an application that is enjoyed by several people, and has been part of KDE for a while. Calling the code “a mess” or “a pile of mud” in public is really not elegant imo. Developers have different code styles and things change over time. Someone might be inexperienced and still contribute a lot. Some projects are more advanced than others, some use older design patterns, etc. In all cases I think we should have some extra care when talking about the work of our predecessors, shouldn’t we?

Leave a Reply

Fill in your details below or click an icon to log in: Logo

You are commenting using your account. Log Out /  Change )

Google+ photo

You are commenting using your Google+ account. Log Out /  Change )

Twitter picture

You are commenting using your Twitter account. Log Out /  Change )

Facebook photo

You are commenting using your Facebook account. Log Out /  Change )


Connecting to %s